[PATCH] D15045: [ELF/AArch64] Rearrange relocations to follow the documentation order. NFC.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 27 07:12:00 PST 2015


ruiu added a comment.

The original order looked random, but the new order also looks somewhat random. Should we instead order them alphabetically? Also, "follow the order in the spec" strategy does not work if some relocations are defined in a separate document (such as TLS relocations.)


================
Comment at: ELF/Target.cpp:943
@@ +942,3 @@
+  case R_AARCH64_ABS64:
+    // No overflow check needed.
+    write64le(Loc, SA);
----------------
Actually I'd remove all these "// no overflow check needed." comments as that's obvious from code.


http://reviews.llvm.org/D15045





More information about the llvm-commits mailing list