[PATCH] D14866: [zorg] Add support for uploading artifacts to the 'llvmlab bisect' bucket and enable this for clang-cmake-mips.

[Charlie Turner via llvm-commits]

chatur01 added a subscriber: chatur01.
chatur01 added a comment.

Hi Daniel,

FWIW, I had a near identical patch locally (making the same decision to add an extra keyword argument, etc...) so it LGTM.  My only interpretation of Galina's suggestion was to create a new function called `getClangGCSBuildFactory(...)` that calls `getClangBuildFactory(...)` and then adds the extra upload step. I don't see what benefit that would bring TBH. Hopefully Galina can clarify.

Have you acquired the relevant credentials to use `gsutil` like this? I asked a while back, and was told I need to make sure everything works OK with my own GCS account before pushing to the official GCS. Unfortunately I'm blocked getting a GCS internally, I'd be interested in hearing what policy you followed to get this commit-ready. If you've demonstrated this works, then that should allow the rest of us Buildbot users to follow your lead and get our builds into the cloud as well.


http://reviews.llvm.org/D14866