[PATCH] D14981: [LoopVectorize] Use MapVector rather than DenseMap for MinBWs.

[David Blaikie via llvm-commits]

On Thu, Nov 26, 2015 at 2:57 AM, Charlie Turner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> chatur01 updated this revision to Diff 41223.
> chatur01 added a comment.
>
> Added a test-case. This might violate the test guidelines of only
> comitting robust test cases. By definition I can't do that for a
> non-determinism bug, but I'm running the test case 5 times, which at least
> locally was always enough to catch the non-determinism on my computer, of
> course I can't guarantee that.
>

No need to have the test actually run 5 times - once is enough to
demonstrate the intended behavior (now that there's an intention to the
ordering of the output). If someone refactored/broke this later, this test
doesn't have to catch it immediately (that person introduced uncertainty in
the output - as you say, you can't guarantee a test for non-determinism,
but you can say "if this test fails, the program isn't behaving as
intended")


>
> I'm requesting a sanity check on my test case before comitting it.
>

If that's the smallest example of unstable output, then it's fine by me - I
don't know enough about the actual code here to know if that's the case so
I'll take yours/James's word for it. But drop the extra runs - just run it
once.

(do no other tests cover the ordering of this output already? What was the
buildbot failure you saw previously that lead you to fix this?)


>
> Many thanks again David for your review.
>
>
> http://reviews.llvm.org/D14981
>
> Files:
>   include/llvm/Analysis/VectorUtils.h
>   lib/Analysis/VectorUtils.cpp
>   lib/Transforms/Vectorize/LoopVectorize.cpp
>   test/Transforms/LoopVectorize/AArch64/deterministic-type-shrinkage.ll
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151126/26ff4348/attachment.html>