[lld] r254105 - Reapply r254098.

[David Blaikie via llvm-commits]

On Wed, Nov 25, 2015 at 11:52 PM, George Rimar <grimar at accesssoftek.com>
wrote:

> >>
> >> Author: grimar
> >> Date: Wed Nov 25 16:15:01 2015
> >> New Revision: 254105
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=254105&view=rev
> >> Log:
> >> Reapply r254098.
> >
> >It's helpful to include the original commit message when recommitting a
> patch so it stands alone/is informative.
> Sorry, I focused on fix part and missed that. Next time will do.
>
> >>
> >> Fix is (OutputSections.cpp):
> >> for (std::pair<const SymbolBody *, size_t> &I : Entries) {
> >>  =>
> >> for (std::pair<const SymbolBody *, unsigned> &I : Entries) {
> >
> >It might be best to use 'auto' to avoid this bug
>
> Yes, but that one passed the review and I didnt wanted to touch it a lot
> because of that. Was not sure about auto here, tried to make minimal
> changes just to fix the buildbot.
>

If it helps, I'll make it a post-commit review request: please change this
to auto because of the subtleties here.

Was this caught by a buildbot with Clang's warning, or due to a test
failing on a machine where size_t != unsigned?

- Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151126/7859da20/attachment.html>