[PATCH] D14947: [tsan] Port tsan_rtl_amd64.S to OS X to add support for setjmp/longjmp

[Dmitry Vyukov via llvm-commits]

dvyukov added inline comments.

================
Comment at: lib/tsan/rtl/tsan_rtl_amd64.S:187
@@ -178,2 +186,3 @@
+  mov %rdi, %rsi
 #else
   lea 16(%rsp), %rdi
----------------
please do:

    #elif defined(__linux__)
    ...
    #else
    # error "Unknown platform"

Initially it was just linux, but now it is unclear what does "#else" mean.


================
Comment at: lib/tsan/rtl/tsan_rtl_amd64.S:226
@@ -210,2 +225,3 @@
+  mov %rdi, %rsi
 #else
   lea 16(%rsp), %rdi
----------------
same here:

    #elif defined(__linux__)

================
Comment at: lib/tsan/rtl/tsan_rtl_amd64.S:297
@@ +296,3 @@
+#else
+  jmp ASM_TSAN_SYMBOL(setjmp)
+#endif
----------------
Will it work with pie binaries?.. are there pie binaries on mac?


http://reviews.llvm.org/D14947