[PATCH] D14983: Introduce new @llvm.getdynamicareaoffset.i{32, 64} intrinsic.

[hfinkel@anl.gov via llvm-commits]

hfinkel added inline comments.

================
Comment at: docs/LangRef.rst:9357
@@ +9356,3 @@
+      The '``llvm.getdynamicareaoffset.*``' intrinsic family is used to
+      get the offset from native SP to the address of the most recent dynamic
+      alloca in the function stack. These intrinsics are intendend for use in
----------------
Please make sure you define what this means, both for stacks that grow down and also for stacks that grow up.

================
Comment at: docs/LangRef.rst:9357
@@ +9356,3 @@
+      The '``llvm.getdynamicareaoffset.*``' intrinsic family is used to
+      get the offset from native SP to the address of the most recent dynamic
+      alloca in the function stack. These intrinsics are intendend for use in
----------------
hfinkel wrote:
> Please make sure you define what this means, both for stacks that grow down and also for stacks that grow up.
SP -> stack pointer

================
Comment at: docs/LangRef.rst:9358
@@ +9357,3 @@
+      get the offset from native SP to the address of the most recent dynamic
+      alloca in the function stack. These intrinsics are intendend for use in
+      combination with :ref:`llvm.stackrestore <int_stackrestore>` to get a
----------------
in the function stack -> on the caller's stack

================
Comment at: docs/LangRef.rst:9361
@@ +9360,3 @@
+      pointer to the most recent dynamic alloca. This is useful for stack
+      unpoisoning routines in AddressSanitizer pass.
+
----------------
This is useful, for example, for AddressSanitizer's stack-unpoisoning routines.

================
Comment at: docs/LangRef.rst:9367
@@ +9366,3 @@
+      These intrinsics return an integer pointer value that can be added to
+      native SP, extracted from :ref:`llvm.stackrestore <int_stackrestore>` or
+      gotten somehow else. The resulting value would be a pointer to the most
----------------
SP -> stack pointer

================
Comment at: docs/LangRef.rst:9368
@@ +9367,3 @@
+      native SP, extracted from :ref:`llvm.stackrestore <int_stackrestore>` or
+      gotten somehow else. The resulting value would be a pointer to the most
+      recent dynamic alloca, allocated by :ref:`alloca <i_alloca>`.
----------------
Remove "or gotten somehow else."

================
Comment at: docs/LangRef.rst:9370
@@ -9340,1 +9369,3 @@
+      recent dynamic alloca, allocated by :ref:`alloca <i_alloca>`.
+
 '``llvm.prefetch``' Intrinsic
----------------
Remember to include the requirement that the return type match the address-space-0 pointer size.


http://reviews.llvm.org/D14983