[PATCH] D14983: Introduce new @llvm.getdynamicareaoffset.i{32, 64} intrinsic.

[Jay Foad via llvm-commits]

foad added inline comments.

================
Comment at: include/llvm/CodeGen/ISDOpcodes.h:758
@@ +757,3 @@
+    /// GET_DYNAMIC_AREA_OFFSET - get offset from native SP to the end of
+    /// dynamic stack area offset. For most targets that would be 0, but for
+    /// some others (e.g. PowerPC, PowerPC64) that would be compile time known
----------------
m.ostepenko wrote:
> hfinkel wrote:
> > offset is repeated twice here in a confusing way. We should define what we mean by "dynamic stack area" - is this one past the end of the last dynamic alloca?
> > offset is repeated twice here in a confusing way.
> Ugh, sorry.
> 
> > We should define what we mean by "dynamic stack area" - is this one past the end of the last dynamic alloca?
> Agreed.
> Under "dynamic stack area" I mean the lowest address of local variable space after the last dynamic alloca. Frankly, I'm not sure "get dynamic stack area offset" is a good description for this intrinsic, any suggestions here are appreciated. 
> We should define what we mean by "dynamic stack area" - is this one past the end of the last dynamic alloca?

How about:

  /// GET_DYNAMIC_AREA_OFFSET - get offset from native SP to the address
  /// of the most recent dynamic alloca.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:5825
@@ +5824,3 @@
+  SDValue FPSIdx = getFramePointerFrameIndex(DAG);
+  // Build a DYNALLOC node.
+  SDValue Ops[2] = { Chain, FPSIdx };
----------------
"DYNAREAOFFSET"


Repository:
  rL LLVM

http://reviews.llvm.org/D14983