[PATCH] D14955: [ELF] - Lazy relocations support for x86 target.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/OutputSections.cpp:292
@@ +291,3 @@
+template <class ELFT> unsigned RelocationSection<ELFT>::getRelocOffset() {
+  unsigned EntrySize = IsRela ? sizeof(Elf_Rela) : sizeof(Elf_Rel);
+  return EntrySize * Relocs.size();
----------------
ruiu wrote:
> Oh OK then you can keep it. Consistency matters.
Done.

================
Comment at: ELF/Target.cpp:225
@@ +224,3 @@
+  if (Config->Shared) {
+    const uint8_t DsoPltData[] = {
+        0xff, 0xb3, 0x04, 0x00, 0x00, 0x00, // pushl 4(%ebx
----------------
ruiu wrote:
> Let's use shorter name as the scope is very narrow.
> 
> DsoPltData -> V
Done.


Repository:
  rL LLVM

http://reviews.llvm.org/D14955