[PATCH] D14955: [ELF] - Lazy relocations support for x86 target.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/OutputSections.cpp:292
@@ +291,3 @@
+template <class ELFT> unsigned RelocationSection<ELFT>::getRelocOffset() {
+  unsigned EntrySize = IsRela ? sizeof(Elf_Rela) : sizeof(Elf_Rel);
+  return EntrySize * Relocs.size();
----------------
Oh OK then you can keep it. Consistency matters.

================
Comment at: ELF/Target.cpp:225
@@ +224,3 @@
+  if (Config->Shared) {
+    const uint8_t DsoPltData[] = {
+        0xff, 0xb3, 0x04, 0x00, 0x00, 0x00, // pushl 4(%ebx
----------------
Let's use shorter name as the scope is very narrow.

DsoPltData -> V


http://reviews.llvm.org/D14955