[PATCH] D14950: [ELF2][MIPS] Support R_MIPS_CALL16 relocation

[Simon Atanasyan via llvm-commits]

atanasyan added inline comments.

================
Comment at: ELF/Target.cpp:116
@@ -115,2 +115,3 @@
   MipsTargetInfo();
+  unsigned getGotRefReloc(unsigned Type) const override;
   void writeGotHeaderEntries(uint8_t *Buf) const override;
----------------
ruiu wrote:
> Please remove this function from this patch.
Hmm, if I remove this function I will always get R_MIPS_GOT16 relocation type into the `relocateOne` routine and so I will not be able to process R_MIPS_GOT16 and R_MIPS_CALL16 differently. In case of R_MIPS_CALL16 I should not check the result on overflow.


Repository:
  rL LLVM

http://reviews.llvm.org/D14950