[PATCH] D14446: Fallback to getpwuid() in path::home_directory() on Unix.

Paweł Bylica via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 05:57:56 PST 2015


chfast added inline comments.

================
Comment at: lib/Support/Unix/Path.inc:558
@@ +557,3 @@
+#ifdef HAVE_PWD_H
+  static const size_t InitialBufSize = 1024;
+  SmallString<InitialBufSize> Buf;
----------------
aaron.ballman wrote:
> Why 1024?
It is suggested initial buffer size returned by `sysconf(_SC_GETPW_R_SIZE_MAX)`.


http://reviews.llvm.org/D14446





More information about the llvm-commits mailing list