[PATCH] D14930: [ELF/x86] Implemented R_386_TLS_LE_32, R_386_TLS_LE relocations.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/InputSection.cpp:150
@@ -149,1 +149,3 @@
       continue;
+    } else if (Target->requireTlsDynReloc(Type)) {
+      continue;
----------------
ruiu wrote:
> require -> requires (since we use "needs" in other places.)
> 
> But maybe isTlsDynReloc is better?
Changed to isTlsDynReloc, thats shorter.

================
Comment at: ELF/OutputSections.cpp:245
@@ -245,1 +244,3 @@
+                            NeedsCopy ? Target->getCopyReloc()
+                                      : Target->replaceDynReloc(Type),
                             Config->Mips64EL);
----------------
ruiu wrote:
> replaceDynReloc -> getDynReloc
Done.


http://reviews.llvm.org/D14930