[lld] r253971 - Reapply fixed r253967.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 03:33:43 PST 2015


>>URL: http://llvm.org/viewvc/llvm-project?rev=253971&view=rev
>>Log:
>>Reapply fixed r253967.
>
>It's helpful to include the original commit message and a note about why the patch was reverted/what was changed/fixed to recommit it - makes review easier (anyone who's looked at the old patch can then pay attention to the new/changed/interesting bits, etc).
>
>- Dave

Ok, will do next time. Just in case fix for that was typename keyword added:

template <class ELFT> static bool isRelroSection(OutputSectionBase<ELFT> *Sec) {
  typename OutputSectionBase<ELFT>::uintX_t Flags = Sec->getFlags();
...
}

MSVS compiled fine and without it.

Best regards,
George.


More information about the llvm-commits mailing list