[PATCH] D14973: Replace all weight-based interfaces in MBB with probability-based interfaces, and update all uses of old interfaces.

[Cong Hou via llvm-commits]

congh created this revision.
congh added reviewers: davidxl, manmanren, dexonsmith.
congh added a subscriber: llvm-commits.
Herald added a reviewer: tstellarAMD.
Herald added subscribers: dsanders, arsenm.

The patch in http://reviews.llvm.org/D13745 is broken into four parts:

1. New interfaces without functional changes (http://reviews.llvm.org/D13908).
2. Use new interfaces in SelectionDAG, while in other passes treat probabilities as weights (http://reviews.llvm.org/D14361).
3. Use new interfaces in all other passes.
4. Remove old interfaces.

This patch is 3+4 above. In this patch, MBB won't provide weight-based interfaces any more, which are totally replaced by probability-based ones. The interface addSuccessor() is redesigned so that the default probability is unknown. We allow unknown probabilities but don't allow using it together with known probabilities in successor list. That is to say, we either have a list of successors with all known probabilities, or all unknown probabilities. In the latter case, we assume each successor has 1/N probability where N is the number of successors. An assertion checks if the user is attempting to add a successor with the disallowed mix use as stated above. This can help us catch many misuses. 

All uses of weight-based interfaces are now updated to use probability-based ones.

http://reviews.llvm.org/D14973

Files:
  include/llvm/Analysis/BranchProbabilityInfo.h
  include/llvm/CodeGen/MachineBasicBlock.h
  include/llvm/CodeGen/MachineBranchProbabilityInfo.h
  include/llvm/Support/BranchProbability.h
  lib/Analysis/BranchProbabilityInfo.cpp
  lib/CodeGen/BranchFolding.cpp
  lib/CodeGen/IfConversion.cpp
  lib/CodeGen/MIRParser/MIParser.cpp
  lib/CodeGen/MIRPrinter.cpp
  lib/CodeGen/MachineBasicBlock.cpp
  lib/CodeGen/MachineBlockPlacement.cpp
  lib/CodeGen/MachineBranchProbabilityInfo.cpp
  lib/CodeGen/TailDuplication.cpp
  lib/Support/BranchProbability.cpp
  lib/Target/AMDGPU/AMDILCFGStructurizer.cpp
  lib/Target/ARM/ARMConstantIslandPass.cpp
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/Hexagon/HexagonCFGOptimizer.cpp
  lib/Target/Mips/MipsLongBranch.cpp
  test/CodeGen/ARM/ifcvt-branch-weight-bug.ll
  test/CodeGen/ARM/ifcvt-branch-weight.ll
  test/CodeGen/ARM/ifcvt-iter-indbr.ll
  test/CodeGen/ARM/tail-merge-branch-weight.ll
  test/CodeGen/ARM/taildup-branch-weight.ll
  test/CodeGen/Generic/MachineBranchProb.ll
  test/CodeGen/Hexagon/ifcvt-edge-weight.ll
  test/CodeGen/MIR/X86/newline-handling.mir
  test/CodeGen/MIR/X86/successor-basic-blocks-weights.mir
  test/CodeGen/MIR/X86/successor-basic-blocks.mir
  test/CodeGen/X86/MachineBranchProb.ll
  test/CodeGen/X86/catchpad-weight.ll
  test/CodeGen/X86/stack-protector-weight.ll
  test/CodeGen/X86/switch-edge-weight.ll
  test/CodeGen/X86/switch-jump-table.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14973.41097.patch
Type: text/x-patch
Size: 66330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151125/c3602d90/attachment-0001.bin>