[PATCH] D14970: ELF: Omit PT_GNU_STACK segment if -z execstack is provided.

Joerg Sonnenberger via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 15:39:20 PST 2015


joerg accepted this revision.
joerg added a comment.
This revision is now accepted and ready to land.

Thanks, this works for the cases I care about. The refinement of the test case is minor, just trying to make sure both cases are handled consistently.


================
Comment at: test/ELF/gnustack.s:9
@@ +8,3 @@
+# RW:       Sections [
+# RW-NOT:   Name: .note.GNU-stack
+# RW:       ProgramHeaders [
----------------
The intention here is that the notes are dropped, so shouldn't that be checked for the RWX case as well?


http://reviews.llvm.org/D14970





More information about the llvm-commits mailing list