[lld] r254003 - Revert "ELF: Make .note.GNU-stack more compatible with traditional linkers."

[Joerg Sonnenberger via llvm-commits]

On Tue, Nov 24, 2015 at 02:23:34PM -0800, Rui Ueyama wrote:
> Omitting PT_GNU_STACK when -z execstack is provided is easy, but it leads
> to a counter-intuitive behavior on platforms that do not recognize
> PT_GNU_STACK and stack is not executable by default. (You need to pass -z
> execstack to make it run on such platforms, but it wouldn't make the stack
> executable.)

That argument makes no sense to me and I am not even sure I understand
it correctly. A platform (like NetBSD) that doesn't recognize
PT_GNU_STACK and provides a non-executable stack by default will not be
affected at all. Yes, it won't do what is intended, but it is no worse
than the current situation of creating a bogus program header either.

Joerg