[PATCH] D14827: Adding support for missing variations of X86 string related instructions

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 13:36:53 PST 2015


rnk added a comment.

In http://reviews.llvm.org/D14827#295822, @myatsina wrote:

> In http://reviews.llvm.org/D14827#295382, @rnk wrote:
>
> > Can you add tests to cover the new error paths you are adding?
>
>
> Do you mean the "mismatching source and destination index registers" error? 
>  If so, then this code is just a refactoring of the old logic that used "doSrcDstMatch" and returned this error if there was no match.
>  It should be covered by existent tests, but I can add one more just in case.


Ah, you're right. Nevermind.


Repository:
  rL LLVM

http://reviews.llvm.org/D14827





More information about the llvm-commits mailing list