[PATCH] D14930: [ELF/x86] Implemented R_386_TLS_LE_32, R_386_TLS_LE relocations.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 24 12:07:33 PST 2015
ruiu added inline comments.
================
Comment at: ELF/InputSection.cpp:150
@@ -149,1 +149,3 @@
continue;
+ } else if (Target->requireTlsDynReloc(Type)) {
+ continue;
----------------
require -> requires (since we use "needs" in other places.)
But maybe isTlsDynReloc is better?
================
Comment at: ELF/OutputSections.cpp:245
@@ -245,1 +244,3 @@
+ NeedsCopy ? Target->getCopyReloc()
+ : Target->replaceDynReloc(Type),
Config->Mips64EL);
----------------
replaceDynReloc -> getDynReloc
http://reviews.llvm.org/D14930
More information about the llvm-commits
mailing list