[llvm] r253918 - [RuntimeDyld] Add accessors to `SectionEntry`; NFC

[Sanjoy Das via llvm-commits]

I couldn't spot anything obviously wrong in the code.  I'm now trying to 
get hold of an ARM box to try and reproduce this.

-- Sanjoy

Renato Golin wrote:
> On 23 November 2015 at 21:47, Sanjoy Das via llvm-commits
> <llvm-commits at lists.llvm.org>  wrote:
>> Author: sanjoy
>> Date: Mon Nov 23 15:47:41 2015
>> New Revision: 253918
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=253918&view=rev
>> Log:
>> [RuntimeDyld] Add accessors to `SectionEntry`; NFC
>>
>> Summary:
>> Remove naked access to the data members in `SectionEntry` and route
>> accesses through accessor functions.  This makes it obvious how the
>> instances of the class are used, and will also facilitate adding bounds
>> checking to `advanceStubOffset` in a later change.
>
> Hi Sanjoy,
>
> One of your three commits broke the AArch64 buildbots:
>
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/2621
>
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/3523
>
> MCJITTests: /home/renato.golin/buildslave/clang-cmake-aarch64-quick/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:386:
>
> void llvm::RuntimeDyldELF::resolveAArch64Relocation(const
> llvm::SectionEntry&, uint64_t, uint64_t, uint32_t, int64_t):
>
> Assertion `(*TargetPtr>>  21&  0x3) == 1&&  "invalid shift for
> relocation"' failed.
>
> cheers,
> --renato