[PATCH] D14889: sancov -not-covered-functions.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.

================
Comment at: lib/Object/ObjectFile.cpp:118
@@ +117,3 @@
+
+Triple ObjectFile::getTriple() const {
+  llvm::Triple TheTriple("unknown-unknown-unknown");
----------------
samsonov wrote:
> pcc wrote:
> > I'd probably prefer if this function returned a `Target *` to reflect the fact that it isn't really supposed to (nor can it) return an accurate triple but rather something that can be used to summon appropriate bits of MC etc.
> Agree: you can't rely deduce triple from object file. At the very least, you should reflect that you're guessing the triple in method name.
Actually it seems that since the MC constructors use the target triple string we should return a triple string here at least for now.


http://reviews.llvm.org/D14889