[PATCH] D14951: [asan] Fix the atos-symbolizer-dyld-root-path.cc test case

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 06:58:13 PST 2015


kubabrecka created this revision.
kubabrecka added reviewers: zaks.anna, samsonov, glider.
kubabrecka added a subscriber: llvm-commits.

Due to a typo, atos-symbolizer-dyld-root-path.cc is currently being skipped all the time.  There's a few more typos/copy-paste-errors.  Let's fix them and enable this test.

http://reviews.llvm.org/D14951

Files:
  test/asan/TestCases/Darwin/atos-symbolizer-dyld-root-path.cc

Index: test/asan/TestCases/Darwin/atos-symbolizer-dyld-root-path.cc
===================================================================
--- test/asan/TestCases/Darwin/atos-symbolizer-dyld-root-path.cc
+++ test/asan/TestCases/Darwin/atos-symbolizer-dyld-root-path.cc
@@ -1,9 +1,10 @@
 // Check that when having a DYLD_ROOT_PATH set, the symbolizer still works.
+// RUN: %clangxx_asan -O0 %s -o %t
 // RUN: %env_asan_opts=verbosity=2 DYLD_ROOT_PATH="/" ASAN_SYMBOLIZER_PATH=$(which atos) \
 // RUN:   not %run %t 2>&1 | FileCheck %s
 //
 // Due to a bug in atos, this only works on x86_64.
-// REQUIRES: x86_64
+// REQUIRES: asan-64-bits
 
 #include <stdlib.h>
 #include <string.h>
@@ -16,11 +17,11 @@
   // CHECK: AddressSanitizer: attempting double-free{{.*}}in thread T0
   // CHECK: Using atos at user-specified path:
   // CHECK: #0 0x{{.*}} in {{.*}}free
-  // CHECK: #1 0x{{.*}} in main {{.*}}atos-symbolizer.cc:[[@LINE-4]]
+  // CHECK: #1 0x{{.*}} in main {{.*}}atos-symbolizer-dyld-root-path.cc:[[@LINE-4]]
   // CHECK: freed by thread T0 here:
   // CHECK: #0 0x{{.*}} in {{.*}}free
-  // CHECK: #1 0x{{.*}} in main {{.*}}atos-symbolizer.cc:[[@LINE-8]]
+  // CHECK: #1 0x{{.*}} in main {{.*}}atos-symbolizer-dyld-root-path.cc:[[@LINE-8]]
   // CHECK: allocated by thread T0 here:
-  // CHECK: atos-symbolizer.cc:[[@LINE-13]]
+  // CHECK: atos-symbolizer-dyld-root-path.cc:[[@LINE-13]]
   return res;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14951.41042.patch
Type: text/x-patch
Size: 1411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151124/ec219a52/attachment.bin>


More information about the llvm-commits mailing list