[PATCH] D14333: [Polly] Cleanup IR after CodeGeneration (WIP)

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Michael,

sorry for the delay. This patch is clearly needed. The approach looks generally fine, but I am slightly concerned about the introduction of a RememberCodegenPass, as pass manager "abuses" are often fragile and I am not 100% convinced this will work with the new pass manager. Instead of trying to figure out if/how to make this work, I would propose to just pass the "is-modified" information as function level metadata or a named function attribute.

Best,
Tobias


================
Comment at: test/ScopInfo/new-domain-construction-schedule-not-freed.ll:6
@@ -5,3 +5,1 @@
 ;
-; CHECK: Statements
-;
----------------
Meinersbur wrote:
> The scop is sometimes removed completely because it has no side effects. This should not be specific to this patch, but occurred occasionally when testing it.
I am confused. Why does a change in the pass manager pipeline affect this test case. The pass manager is not even involved here, no?


http://reviews.llvm.org/D14333