[PATCH] D14361: Let SelectionDAG start to use probability-based interface to add successors.

Cong Hou via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 22:02:57 PST 2015


congh added a comment.

In http://reviews.llvm.org/D14361#295596, @davidxl wrote:

> The test case change look sane -- the weight ratio do not change before and after (and after Weight based interface is deprecated, the check-weight will become check-prob).
>
> the only test that needs double check is the powerPC one -- is the change expected?


The change is from block placement. This is actually a previous bug. Note the change in lib/Target/PowerPC/PPCISelLowering.cpp: 0 and 1 are added as weights but 0 is later transformed into 16. Instead we use a very small and large probabilities to replace them. That is why that test case is updated.


http://reviews.llvm.org/D14361





More information about the llvm-commits mailing list