[PATCH] D14889: sancov -not-covered-functions.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 17:52:06 PST 2015


pcc added inline comments.

================
Comment at: lib/Object/ObjectFile.cpp:118
@@ +117,3 @@
+
+Triple ObjectFile::getTriple() const {
+  llvm::Triple TheTriple("unknown-unknown-unknown");
----------------
I'd probably prefer if this function returned a `Target *` to reflect the fact that it isn't really supposed to (nor can it) return an accurate triple but rather something that can be used to summon appropriate bits of MC etc.


http://reviews.llvm.org/D14889





More information about the llvm-commits mailing list