[PATCH] D14827: Adding support for missing variations of X86 string related instructions

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 14:14:24 PST 2015


rnk added a comment.

Can you add tests to cover the new error paths you are adding?


================
Comment at: test/MC/X86/intel-syntax.s:740-741
@@ +739,4 @@
+
+ins byte ptr [eax], dx
+// CHECK: insb %dx, %es:(%edi)
+outs dx, word ptr [eax]
----------------
I'm confused. Why are these two assembly instructions equivalent? Ditto for the rest, they don't look equivalent.


Repository:
  rL LLVM

http://reviews.llvm.org/D14827





More information about the llvm-commits mailing list