[PATCH] D14894: [PGO] Add --text-format option for llvm-profdata show|merge commands

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/ProfileData/InstrProfWriter.cpp:188
@@ -174,1 +187,3 @@
+}
+
 std::unique_ptr<MemoryBuffer> InstrProfWriter::writeBuffer() {
----------------
dnovillo wrote:
> I would move this functionality into lib/ProfileData itself.  See how the sample writers are organized.  From llvm-profdata, you can then just select the kind of writer to use.
The change is in lib/ProfileData. There is no need to create a new InstrProfWriter subtype text -- it is much simpler to just add a new writer interface for text.

================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:35
@@ -35,1 +34,3 @@
+
+static void exitWithError(const Twine &Message, StringRef Whence = "",
                           StringRef Hint = "") {
----------------
vsk wrote:
> Could you handle this in a follow-up commit?
clang-format did this for me. will revert this part.


http://reviews.llvm.org/D14894