[PATCH] D14917: [ELF/AArch64] Add support for R_AARCH64_ADR_GOT_PAGE and R_AARCH64_LD64_GOT_LO12_NC.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 10:09:25 PST 2015
ruiu accepted this revision.
ruiu added a comment.
LGTM with a nit.
================
Comment at: ELF/Target.cpp:672-673
@@ -665,3 +671,4 @@
const SymbolBody &S) const {
- return relocNeedsPlt(Type, S);
+ return (Type == R_AARCH64_ADR_GOT_PAGE) ||
+ (Type == R_AARCH64_LD64_GOT_LO12_NC) || relocNeedsPlt(Type, S);
}
----------------
Remove ()s. (We can assume that everybody knows that == takes precedence over ||.)
http://reviews.llvm.org/D14917
More information about the llvm-commits
mailing list