[PATCH] D14892: Add Windows error code and tidy formatting for system errors

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 09:36:48 PST 2015


probinson marked an inline comment as done.

================
Comment at: lib/Support/Windows/WindowsSupport.h:51
@@ -49,2 +50,3 @@
   char *buffer = NULL;
   DWORD R = FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER |
+                          FORMAT_MESSAGE_FROM_SYSTEM |
----------------
rnk wrote:
> According to MSDN, this call can update the last error code. You might want to cache it locally at the beginning of this function.
Ah, thanks for catching that.


http://reviews.llvm.org/D14892





More information about the llvm-commits mailing list