[PATCH] D14917: [ELF/AArch64] Add support for R_AARCH64_ADR_GOT_PAGE and R_AARCH64_LD64_GOT_LO12_NC.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 08:46:27 PST 2015


davide added inline comments.

================
Comment at: ELF/Target.cpp:678
@@ -667,1 +677,3 @@
+    return true;
+  }
 }
----------------
ikudrin wrote:
> davide wrote:
> > cant' this just be a one-liner?
> > something like
> > return R_AARCH64_ADR_GOT_PAGE || R_AARCH64_LD64_GOT_LO12_NC || relocNeedsPlt();
> We may have more GOT relocations in the near future, like R_AARCH64_*_GOTOFF_*, R_AARCH64_GOT_LD_PREL19, R_AARCH64_LD64_GOTPAGE_LO15.
If we'll get there, we can switch over. I'm for simplicity until we need something more complicated.


http://reviews.llvm.org/D14917





More information about the llvm-commits mailing list