[PATCH] D14761: [X86][SSE] Detect AVG pattern during instruction combine for SSE2/AVX2/AVX512BW.

[Cong Hou via llvm-commits]

congh added inline comments.

================
Comment at: test/CodeGen/X86/avg.ll:4
@@ +3,3 @@
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=x86-64 -mattr=+avx512bw | FileCheck %s --check-prefix=AVX512BW
+
+define void @avg_v4i8(<4 x i8> %a, <4 x i8> %b) {
----------------
congh wrote:
> RKSimon wrote:
> > AVX2/AVX512BW can share an additional AVX prefix - reduce test duplication:
> > 
> > FileCheck %s --check-prefix=AVX --check-prefix=AVX2
> > FileCheck %s --check-prefix=AVX --check-prefix=AVX512BW
> > 
> I don't get it here: I didn't use AVX prefix at all. Should I test all SSE versions?
Now I know what you mean: for some test cases AVX2 and AVX512BW generate the same code. Thanks for the suggestion!


http://reviews.llvm.org/D14761