[PATCH] D14907: [tsan] Fix weakly imported functions on OS X

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 22 11:37:41 PST 2015


kubabrecka created this revision.
kubabrecka added reviewers: dvyukov, kcc, glider, samsonov.
kubabrecka added subscribers: llvm-commits, zaks.anna, ismailp.

On OS X, for weak function (that user can override by providing their own implementation in the main binary), we need `extern "C" SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE NOINLINE`.

Fixes a broken test case on OS X, java_symbolization.cc, which uses a weak function __tsan_symbolize_external.

http://reviews.llvm.org/D14907

Files:
  lib/sanitizer_common/sanitizer_internal_defs.h
  lib/tsan/rtl/tsan_flags.cc
  lib/tsan/rtl/tsan_mman.cc
  lib/tsan/rtl/tsan_rtl.cc
  lib/tsan/rtl/tsan_rtl_report.cc
  lib/tsan/rtl/tsan_suppressions.cc
  lib/tsan/rtl/tsan_symbolize.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14907.40881.patch
Type: text/x-patch
Size: 3935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151122/a1d7489d/attachment.bin>


More information about the llvm-commits mailing list