[llvm] r253810 - Temporary fix broken build.ninja after r253790.

[Krzysztof Parzyszek via llvm-commits]

Yeah, it left a bunch of ninja builders in a non-workable state, even 
after the revert.  In many cases I fixed that by forcing a build of 
r249999, which then forced re-cmaking everything.  One case remained 
broken (sanitizer-x86_64-linux-fast).

Sorry about that. The build worked for me locally, because I did it over 
a previous build (and Attributes.inc was already present).

-Krzysztof


On 11/21/2015 8:32 PM, NAKAMURA Takumi via llvm-commits wrote:
> Author: chapuni
> Date: Sat Nov 21 20:32:49 2015
> New Revision: 253810
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253810&view=rev
> Log:
> Temporary fix broken build.ninja after r253790.
>
> FIXME: This can be reverted several hours later.
>
> r253790 introduced cyclic deps around llvm-tblgen and it was affecting after reverting.
>
>    ninja: error: dependency cycle: include/llvm/IR/Attributes.inc -> include/llvm/IR/Attributes.inc.tmp -> bin/llvm-tblgen -> utils/TableGen/CMakeFiles/obj.llvm-tblgen.dir/DFAPacketizerEmitter.cpp.o -> include/llvm/IR/Attributes.inc
>
> It may be a ninja's bug.
>
> FYI, renaming DFAPacketizerEmitter.cpp would be useless.
>
> Modified:
>      llvm/trunk/include/llvm/IR/Attributes.h
>      llvm/trunk/include/llvm/IR/CMakeLists.txt
>
> Modified: llvm/trunk/include/llvm/IR/Attributes.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Attributes.h?rev=253810&r1=253809&r2=253810&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/IR/Attributes.h (original)
> +++ llvm/trunk/include/llvm/IR/Attributes.h Sat Nov 21 20:32:49 2015
> @@ -65,7 +65,7 @@ public:
>       // IR-Level Attributes
>       None,                  ///< No attributes have been set
>       #define GET_ATTR_ENUM
> -    #include "llvm/IR/Attributes.inc"
> +    #include "llvm/IR/Attributes_renamed.inc"
>       EndAttrKinds           ///< Sentinal value useful for loops
>     };
>
>
> Modified: llvm/trunk/include/llvm/IR/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/CMakeLists.txt?rev=253810&r1=253809&r2=253810&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/IR/CMakeLists.txt (original)
> +++ llvm/trunk/include/llvm/IR/CMakeLists.txt Sat Nov 21 20:32:49 2015
> @@ -1,5 +1,5 @@
>   set(LLVM_TARGET_DEFINITIONS Attributes.td)
> -tablegen(LLVM Attributes.inc -gen-attrs)
> +tablegen(LLVM Attributes_renamed.inc -gen-attrs)
>
>   set(LLVM_TARGET_DEFINITIONS Intrinsics.td)
>   tablegen(LLVM Intrinsics.gen -gen-intrinsic)
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation