[PATCH] D14849: ELF: Make .note.GNU-stack handling compatible with traditional linkers.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 21 14:17:08 PST 2015
ruiu added inline comments.
================
Comment at: ELF/InputFiles.cpp:178
@@ -177,2 +177,3 @@
+ bool hasGnuStack = false;
const ELFFile<ELFT> &Obj = this->ELFObj;
for (const Elf_Shdr &Sec : Obj.sections()) {
----------------
grimar wrote:
> Wih a nit: variable uses low case, should be:
>
> ```
> bool HasGnuStack = false;
> ```
Done
http://reviews.llvm.org/D14849
More information about the llvm-commits
mailing list