[PATCH] D14361: Let SelectionDAG start to use probability-based interface to add successors.
Cong Hou via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 20 16:54:23 PST 2015
congh added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1312
@@ -1311,3 +1311,3 @@
UnwindDest.first->setIsEHPad();
- addSuccessorWithWeight(FuncInfo.MBB, UnwindDest.first, UnwindDest.second);
+ addSuccessorWithProb(FuncInfo.MBB, UnwindDest.first, UnwindDest.second);
}
----------------
davidxl wrote:
> Let's add a TODO here for a follow up. In follow up, find a way to assert the violations and examine the root cause
OK. But why here? It is a specific place and the follow up is fixing a more general problem. After the whole patch is checked in, I will work on how to validate the successors' probabilities.
It this patch ready? I will update the test cases.
http://reviews.llvm.org/D14361
More information about the llvm-commits
mailing list