[PATCH] D14849: ELF: Make .note.GNU-stack handling compatible with traditional linkers.

[George Rimar via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Driver.cpp:286
@@ -280,1 +285,3 @@
+    Config->ZExecStack = false;
+
   if (Config->OutputFile.empty())
----------------
Oh, I missed this is called after handling files, sorry.

================
Comment at: ELF/InputFiles.cpp:247
@@ -242,2 +246,3 @@
+    Config->ZExecStack = true;
 }
 
----------------
Yes, you`re right here too. I was for some reason sure that files are iterated in a loop in this method sharing the single flag. 
Applied patch and everything became clear. Sorry, will always do that next time :)


http://reviews.llvm.org/D14849