Review for compiler-rt build fix

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 15:19:41 PST 2015


Looks good to me. Thanks for the fix.

David

On Fri, Nov 20, 2015 at 3:16 PM, Matthias Braun <mbraun at apple.com> wrote:

> Hi Xinliang,
>
> could you please do a post-commit review of r253735. I don't know much
> about how the compiler-rt build is supposed to work, but I assume new files
> have to be mentioned in clang_linux.mk and clang_darwin.mk as well...
>
> (This is an attempt to fix our internal PGO bots which currently produce:
> Undefined symbols for architecture arm64:
>   "_llvmWriteProfData", referenced from:
>       ___llvm_profile_write_file in
> libclang_rt.profile_ios.a(InstrProfilingFile.o)
> )
>
> - Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151120/d6074c3c/attachment.html>


More information about the llvm-commits mailing list