[llvm] r253705 - [Hexagon] Fix the return value from HexagonGenInsert::runOnMachineFunction

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 12:46:23 PST 2015


Author: kparzysz
Date: Fri Nov 20 14:46:23 2015
New Revision: 253705

URL: http://llvm.org/viewvc/llvm-project?rev=253705&view=rev
Log:
[Hexagon] Fix the return value from HexagonGenInsert::runOnMachineFunction

Modified:
    llvm/trunk/lib/Target/Hexagon/HexagonGenInsert.cpp

Modified: llvm/trunk/lib/Target/Hexagon/HexagonGenInsert.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonGenInsert.cpp?rev=253705&r1=253704&r2=253705&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Hexagon/HexagonGenInsert.cpp (original)
+++ llvm/trunk/lib/Target/Hexagon/HexagonGenInsert.cpp Fri Nov 20 14:46:23 2015
@@ -1495,7 +1495,7 @@ bool HexagonGenInsert::runOnMachineFunct
   // version of DCE that preserves lifetime markers. Without it, merging
   // of stack objects can fail to recognize and merge disjoint objects
   // leading to unnecessary stack growth.
-  removeDeadCode(MDT->getRootNode());
+  Changed = removeDeadCode(MDT->getRootNode());
 
   const HexagonEvaluator HE(*HRI, *MRI, *HII, MF);
   BitTracker BTLoc(HE, MF);
@@ -1533,7 +1533,7 @@ bool HexagonGenInsert::runOnMachineFunct
   }
 
   if (IFMap.empty())
-    return false;
+    return Changed;
 
   {
     NamedRegionTimer _T("pruning", "hexinsert", TimingDetail);
@@ -1546,7 +1546,7 @@ bool HexagonGenInsert::runOnMachineFunct
   }
 
   if (IFMap.empty())
-    return false;
+    return Changed;
 
   {
     NamedRegionTimer _T("selection", "hexinsert", TimingDetail);
@@ -1571,13 +1571,15 @@ bool HexagonGenInsert::runOnMachineFunct
     for (unsigned i = 0, n = Out.size(); i < n; ++i)
       IFMap.erase(Out[i]);
   }
+  if (IFMap.empty())
+    return Changed;
 
   {
     NamedRegionTimer _T("generation", "hexinsert", TimingDetail);
-    Changed = generateInserts();
+    generateInserts();
   }
 
-  return Changed;
+  return true;
 }
 
 




More information about the llvm-commits mailing list