[PATCH] D14199: [compiler-rt] [tsan] Unify aarch64 mapping

[Dmitry Vyukov via llvm-commits]

dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with nits

sorry for delays and thanks for bearing with me


================
Comment at: lib/tsan/rtl/tsan_platform.h:248
@@ +247,3 @@
+  switch (Type) {
+#if !defined(SANITIZER_GO)
+    case MAPPING_LO_APP_BEG: return Mapping::kLoAppMemBeg;
----------------
#ifndef SANITIZER_GO
that's more common throughout tsan

================
Comment at: lib/tsan/rtl/tsan_platform.h:256
@@ +255,3 @@
+    case MAPPING_VDSO_BEG: return Mapping::kVdsoBeg;
+#elif defined(SANITIZER_GO)
+    case MAPPING_APP_BEG: return Mapping::kAppMemBeg;
----------------
#else

================
Comment at: lib/tsan/rtl/tsan_platform.h:315
@@ -240,1 +314,3 @@
 
+#elif defined(SANITIZER_GO) && !SANITIZER_WINDOWS
+
----------------
drop !SANITIZER_WINDOWS part

================
Comment at: lib/tsan/rtl/tsan_rtl.cc:291
@@ +290,3 @@
+    uptr beg, end;
+    if (!GetUserRegion (i, &beg, &end))
+      break;
----------------
please replace this with:

	uptr beg, end;
	for (int i = 0; GetUserRegion(i, &beg, &end); i++) {

it is shorter and more idiomatic for loops.



http://reviews.llvm.org/D14199