[compiler-rt] r253483 - [PGO] Runtime support for value profiling.

[Daniel Sanders via llvm-commits]

My focus at the moment is making the buildbot green again since the longer it's red the greater the chance of later failures going unnoticed. Is my intended revert likely to break other buildbots? If so, we should probably revert the other pieces of this too and re-commit them once these problems are solved.

> It looks like that the references to  __sycn_fetch_and_add operations are
> not defined for your target. Is there an alternative that you'd like us to use
> (mutex lock/unlock  based operation)?

The problem is probably limited to __sync_fetch_and_add_8 since MIPS32 lacks 64-bit atomics operations. As for alternate solutions, I haven't thought that far yet since restoring the buildbots is more important.

By the way, I looked through the other failing buildbots and sanitizer_x86_64-freebsd (http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6550/) looks like it might have been broken by this commit too.

> -----Original Message-----
> From: Betul Buyukkurt [mailto:betulb at codeaurora.org]
> Sent: 20 November 2015 17:21
> To: Daniel Sanders; 'Renato Golin'; 'Xinliang David Li'; llvm-
> commits at lists.llvm.org
> Subject: RE: [compiler-rt] r253483 - [PGO] Runtime support for value
> profiling.
> 
> Hi Daniel,
> 
> This was the merging of a runtime support of the value profiling feature
> which was merged along w/ the LLVM and clang counterparts of this work.
> Those were r253484 and r253485 respectively.
> 
> It looks like that the references to  __sycn_fetch_and_add operations are
> not defined for your target. Is there an alternative that you'd like us to use
> (mutex lock/unlock  based operation)?
> 
> -Betul
> 
> -----Original Message-----
> From: Daniel Sanders [mailto:Daniel.Sanders at imgtec.com]
> Sent: Friday, November 20, 2015 8:29 AM
> To: Daniel Sanders; Renato Golin; Betul Buyukkurt; Xinliang David Li; llvm-
> commits at lists.llvm.org
> Subject: RE: [compiler-rt] r253483 - [PGO] Runtime support for value
> profiling.
> 
> Not sure why I re-added (Outlook removes the list) llvm-dev instead of llvm-
> commits on that last one, sorry.
> 
> I missed a few fixup commits in the last list. Reverting r253545, r253510,
> r253508, r253503, r253500, r253496, r253492, r253489, and r253483 (all of
> which are part of this commit and the corrections) fixes the failing tests in my
> working copy. I'm going to do a full 'ninja check-all' before I revert.
> 
> > -----Original Message-----
> > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of
> > Daniel Sanders via llvm-dev
> > Sent: 20 November 2015 16:05
> > To: Renato Golin; Betul Buyukkurt; llvm-dev at lists.llvm.org; Xinliang
> > David Li
> > Subject: Re: [llvm-dev] [compiler-rt] r253483 - [PGO] Runtime support
> > for value profiling.
> >
> > Hi,
> >
> > I'm currently bisecting a buildbot regression in the clang-cmake-mips
> > builder and I've ended up with a range of commits, all of them are
> > either this commit or one of its corrections. The commits are r253483,
> > r253489, r253492, and r253496. I'm going to try reverting these in my
> > working copy and if that works I'll commit the revert.
> >
> > The first build to fail is
> > http://lab.llvm.org:8011/builders/clang-cmake-
> > mips/builds/10816 and the first one to show the current failures is
> > http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/10819.
> >
> > > -----Original Message-----
> > > From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
> > Behalf
> > > Of Renato Golin via llvm-commits
> > > Sent: 18 November 2015 21:46
> > > To: Betul Buyukkurt
> > > Cc: LLVM Commits
> > > Subject: Re: [compiler-rt] r253483 - [PGO] Runtime support for value
> > > profiling.
> > >
> > > On 18 November 2015 at 18:12, Betul Buyukkurt via llvm-commits
> > > <llvm-commits at lists.llvm.org> wrote:
> > > > Author: betulb
> > > > Date: Wed Nov 18 12:12:35 2015
> > > > New Revision: 253483
> > > >
> > > > URL: http://llvm.org/viewvc/llvm-project?rev=253483&view=rev
> > > > Log:
> > > > [PGO] Runtime support for value profiling.
> > > >
> > > > This change adds extends the data structures and adds in the
> > > > routines for handling runtime calls for value profiling. The
> > > > profile data format is modified and the version number is incremented.
> > >
> > > Hi Betul,
> > >
> > > There has been a good number of commits and the self-hosting bots
> > > are still broken, shouldn't we revert everything and try again,
> > > *after* you make it self-host locally?
> > >
> > > http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/
> > > 9175
> > >
> > > You're making it very hard to revert this patch already...
> > >
> > > cheers,
> > > --renato
> > > _______________________________________________
> > > llvm-commits mailing list
> > > llvm-commits at lists.llvm.org
> > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev