[PATCH] D14873: [tsan] Modify the tls_race.cc and tls_race2.cc tests to pass on OS X

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 08:31:05 PST 2015


dvyukov added inline comments.

================
Comment at: test/tsan/tls_race.cc:23
@@ +22,2 @@
+// CHECK-FreeBSD:   Location is TLS of main thread.
+// CHECK-Darwin:   Location is heap block of size 4
----------------
How does the heap block allocation stack look like? Is it possible to figure out that this is TLS from the stack?


================
Comment at: test/tsan/tls_race2.cc:28
@@ -27,3 +27,3 @@
 // CHECK: WARNING: ThreadSanitizer: data race
-// CHECK:   Location is TLS of thread T1.
-
+// CHECK-Linux:   Location is TLS of main thread.
+// CHECK-FreeBSD:   Location is TLS of main thread.
----------------
revert this back to "thread T1"


http://reviews.llvm.org/D14873





More information about the llvm-commits mailing list