[PATCH] D14841: [PGO] profile runtime naming cleanups
Betul Buyukkurt via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 20 05:41:34 PST 2015
betulb added inline comments.
================
Comment at: lib/profile/InstrProfiling.h:40
@@ +39,3 @@
+ IPVK_Last = IPVK_IndirectCallTarget
+
+};
----------------
Extra line. Please remove.
================
Comment at: lib/profile/InstrProfiling.h:51
@@ -49,3 +50,3 @@
struct __llvm_profile_value_node *Next;
} __llvm_profile_value_node;
----------------
Please remove the __llvm_profile_value_node struct.
================
Comment at: lib/profile/InstrProfiling.h:123
@@ -120,3 +122,3 @@
* Prepares a single __llvm_profile_value_data array out of the many
* __llvm_profile_value_node trees (one per instrumented function).
*/
----------------
Remove the reference to __llvm_profile_value_node.
http://reviews.llvm.org/D14841
More information about the llvm-commits
mailing list