[PATCH] D14855: [tsan] Support thread sanitizer on Android.

Dan Albert via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 21:43:38 PST 2015


danalbert added inline comments.

================
Comment at: lib/tsan/rtl/tsan_interceptors.h:35
@@ -34,3 +34,3 @@
     }                                                    \
-    if (thr->ignore_interceptors || thr->in_ignored_lib) \
+    if (!thr->is_inited || thr->ignore_interceptors || thr->in_ignored_lib) \
       return REAL(func)(__VA_ARGS__); \
----------------
I can't say much for the rest of the change, but the `is_inited` checks can easily be a separate, smaller patch, and I can pretty much guarantee that someone else would say so if I didn't :)


http://reviews.llvm.org/D14855





More information about the llvm-commits mailing list