[PATCH] D13363: [DeadStoreElimination] Add support for non-local DSE

[Mitch Bodart via llvm-commits]

mbodart added a comment.

Hi Ivan,

I would stll like to see a source comment near the DT->dominates(BB, Pred) check in findSafePreds,
as its necessity is not otherwise obvious.   It is needed in order to prevent unsafe use of isOverwrite
and potentially other AA interfaces.  For example isOverwrite cannot be trusted if the pointer values
in question could come from different iterations of an enclosing loop.

Otherwise LGTM.

I think you'll need to update to ToT once again, as there was another change in DeadStoreElimination.cpp
which prevented the patch from applying cleanly.

- mitch


http://reviews.llvm.org/D13363