[PATCH] D14833: [ELF] Define symbols "_end" and "end" if referenced.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM with nits.


================
Comment at: ELF/Symbols.cpp:90
@@ -89,2 +89,3 @@
   DefinedAbsolute<ELFT>::IgnoreUndef.setVisibility(STV_HIDDEN);
+  DefinedAbsolute<ELFT>::End.setBinding(STB_GLOBAL);
   Undefined<ELFT>::Optional.setVisibility(STV_HIDDEN);
----------------
Sort.

================
Comment at: ELF/Writer.cpp:899
@@ -881,1 +898,3 @@
 
+  // Update "_end" and, possibly, "end" symbols so that them
+  // point to the end of the data segment.
----------------
them -> they


http://reviews.llvm.org/D14833