[PATCH] D14833: [ELF] Define symbols "_end" and "end" is referenced.
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 11:26:33 PST 2015
hmm, for some reason phabricator doesn't put my comment at the correct
line. When I say this can be removed I mean "type"
e.g.
+// DEFAULT-NEXT: Type: SHT_NOBITS
On Thu, Nov 19, 2015 at 11:25 AM, Davide Italiano <dccitaliano at gmail.com> wrote:
> davide added inline comments.
>
> ================
> Comment at: test/ELF/end-update.s:10
> @@ +9,3 @@
> +// CHECK: Name: .bss
> +// CHECK-NEXT: Type: SHT_NOBITS
> +// CHECK-NEXT: Flags [
> ----------------
> This can be removed.
>
> ================
> Comment at: test/ELF/end.s:12
> @@ +11,3 @@
> +// DEFAULT: Name: .bss
> +// DEFAULT-NEXT: Type: SHT_NOBITS
> +// DEFAULT-NEXT: Flags [
> ----------------
> This can be removed. Same for all the others (I think)
>
> ================
> Comment at: test/ELF/end.s:13
> @@ +12,3 @@
> +// DEFAULT-NEXT: Type: SHT_NOBITS
> +// DEFAULT-NEXT: Flags [
> +// DEFAULT-NEXT: SHF_ALLOC
> ----------------
> This can be removed.
>
>
> http://reviews.llvm.org/D14833
>
>
>
More information about the llvm-commits
mailing list