[PATCH] D14470: [asan] Fix the deadlocks introduced by "On OS X, log reports to syslog and os_trace" commit

[Alexey Samsonov via llvm-commits]

samsonov added a comment.

Sorry for the delay in review! =/


================
Comment at: lib/asan/asan_report.cc:52
@@ -51,3 +51,3 @@
   if (!error_message_buffer) {
-    error_message_buffer_size = 1 << 16;
+    error_message_buffer_size = ErrorMessageBufferSize;
     error_message_buffer =
----------------
Do you actually need this variable at all, now that you have a constant?

================
Comment at: lib/sanitizer_common/sanitizer_posix.cc:125
@@ +124,3 @@
+    else
+      ReportMmapFailureAndDie(size, mem_type, "allocate", reserrno);
+  }
----------------
This function is now called in several more places. You might want to just add extra argument (raw_report) to ReportMmapFailureAndDie to reduce code duplication.


http://reviews.llvm.org/D14470