[PATCH] D14778: [PPC64] Enable shrink wrapping for PPC64 LE.
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 09:15:07 PST 2015
qcolombet added inline comments.
================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:585
@@ +584,3 @@
+
+ if (MBBI != MBB->begin())
+ RS.forward(MBBI);
----------------
kbarton wrote:
> qcolombet wrote:
> > You still need to check that “begin” is not the terminator, otherwise, you’ll get the available register after the terminator, not before.
> Maybe I misunderstand, but this check should cover that.
> MBBI is initialized to MBB->getFirstTerminator() above, so the iterator will not move forward if begin is the terminator.
You’re right. Looks like I need vacations :).
http://reviews.llvm.org/D14778
More information about the llvm-commits
mailing list