[PATCH] D14183: [AArch64]Extend merging narrow loads into a wider load

[Chad Rosier via llvm-commits]

mcrosier accepted this revision.
mcrosier added a comment.

LGTM with a minor nit.  Please make sure the refactoring of isSmallTypeLdMerge->isNarrowLoad, etc lands after this..


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:616
@@ -566,1 +615,3 @@
 
+    int width = getMemScale(I) == 1 ? 8 : 16;
+    int lsbLow = 0;
----------------
In general, variable names should begin with a capital letter and are written in camel case.

width -> Width
lsbLow -> LSBLow or LsbLow
lsbHigh -> LSBHigh or LsbHigh
immsLow -> ImmsLow
immsHigh -> ImmsHigh


http://reviews.llvm.org/D14183