[PATCH] D14720: [llvm-profdata] Add SaturatingAdd/SaturatingMultiply Helper Functions
Diego Novillo via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 05:03:23 PST 2015
dnovillo added a comment.
In http://reviews.llvm.org/D14720#290631, @slingn wrote:
> Related question:
>
> Is it by design that intstr profile count overflow is treated differently from sample profile count overflow?
> Instr profile merging appears to skip records that would result in overflow and print a warning. Sample profile count overflow saturates and does not show a warning.
Sample PGO will warn when the weights read from the profile saturate 32-bit values. Showing a warning in llvm-profdata when adding 64 bit values sounds like a good idea.
Repository:
rL LLVM
http://reviews.llvm.org/D14720
More information about the llvm-commits
mailing list