[PATCH] D14803: [AArch64] Fix a corner case in BitFeild select

[Mandeep Singh Grang via llvm-commits]

mgrang added a comment.

Please fix the typo in the commit title:

  BitFeild ==> BitField


================
Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1699
@@ -1698,1 +1698,3 @@
 
+  // trivially true.
+  if (BitWidth == 0)
----------------
Comments should begin with an uppercase letter.

================
Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1700
@@ +1699,3 @@
+  // trivially true.
+  if (BitWidth == 0)
+    return true;
----------------
Can we change this to if (!BitWidth) ?

================
Comment at: test/CodeGen/AArch64/bitfield-pr25571.ll:2
@@ +1,3 @@
+; ModuleID = 'bugpoint-reduced-simplified.bc'
+;RUN: llc -verify-machineinstrs < %s | FileCheck %s
+target datalayout = "e-m:e-i64:64-i128:128-n8:16:32:64-S128"
----------------
Space between ;RUN


http://reviews.llvm.org/D14803